Pr from fork/137 #254
Pr from fork/137 #254
Conversation
…umented; needs CALI_CONFIG env variable for output
…ant, kernelvariant
…on across variants
…metric to work with older Hatchet
… exiting full path to executable
…book with ipynb file type
…vary in number of kernels
…anup of caliper includes
…ll bring in Caliper native reader and adiak, removing our reliance on caliper.py
It can now take strings with spaces as executables. This allows you to treat things like "srun -n8 ./bin/raja_perf.exe" as an executable.
src/rajaperf_config.hpp.in
Outdated
| constexpr static const char* adiak_systype_build = "@RAJAPERF_BUILD_SYSTYPE@"; | ||
| constexpr static const char* adiak_machine_build = "@RAJAPERF_BUILD_HOST@"; | ||
| #endif | ||
|
|
||
| #if 0 |
There was a problem hiding this comment.
I believe this '#if 0' section can be removed if the new code works
|
@jonesholger I pushed several changes that addressed a good chunk of my review comments and resolved those conversations. A few open items remain. |
|
@rhornung67 Thank you for the changes. I think we're very close now. |
|
Sounds good. I think Adrien wants to get this merged. Send a ping when it's ready. |
…g from doc and referring to file with function, or note indicating dependency version
|
@rhornung67 @MrBurmark @adrienbernede Should be good to go. I think next on the Agenda is a couple of walk throughs of the tutorial and another meeting with stakeholders @pearce8 @slabasan. WRT tutorial I'll move it from WIP to review. There are some hard commit hashes that will need to be revised in tutorial git checkouts, when this branch is merged and again at a release juncture. |
|
@rhornung67 We should close this, right ? |
Pull Caliper PR from forked repo into RAJAPerf repo
Original PR is #137 Please refer to original PR discussion there, but review and approve this one for merging.