Fix authenticate, remove app bridge from auth full redirect page #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsalguero94
reviewed
Nov 15, 2024
Comment on lines
4
to
9
| <meta charset="utf-8"> | ||
| <base target="_top"> | ||
| <meta name="shopify-api-key" content="{{ \Osiset\ShopifyApp\Util::getShopifyConfig('api_key', $shopDomain ?? Auth::user()->name ) }}"/> | ||
| <script src="https://cdn.shopify.com/shopifycloud/app-bridge.js"></script> | ||
|
|
||
| <title>Redirecting...</title> | ||
|
|
There was a problem hiding this comment.
why do we need this view? it works if we make the redirect from the controller without using the view.
There was a problem hiding this comment.
As I mentioned in the issue, there is no difference; both options will likely work the same way.
However, someone might be using this view to send analytics via sendBeacon or for something else. I can't make any definitive statements here.
Personally, I don't use the authenticate route at all—it's not necessary during a token exchange.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that App Bridge redirected the user back to Shopify before the JavaScript script had a chance to run.
In theory, after being redirected back to Shopify, our script should have executed, but since we were not yet authenticated at that moment, an error occurred.