Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting 404 on /authenticate after updating to v22.0.0 #363

Open
VivekShingala opened this issue Nov 15, 2024 · 5 comments
Open

Getting 404 on /authenticate after updating to v22.0.0 #363

VivekShingala opened this issue Nov 15, 2024 · 5 comments
Labels
bug Something isn't working unconfirmed Bug has not been reproduced yet

Comments

@VivekShingala
Copy link

For bug reporting only! If you're posting a feature request or discussion, please ignore.

Expected Behavior

App installation should work and authenticate the shop

Current Behavior

Getting 'There's no page at this address' on /authenticate

Failure Information

Uninstall webhook is working, but installation fails for new and existing shops with 404 error on Shopify store.

Steps to Reproduce

  1. Create new test shop or uninstall the app from the shop
  2. Try to install the app
  3. Authentication fails and Shopify throws 404 error
  4. Latest version of this repo is used

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Package Version: v22.0.0
  • Laravel Version: 11.20.0
  • PHP Version: 8.3.12
  • Template Engine: Blade
  • Using a toolset (Docker, Laradock, Vagrant, etc.): No (Nginx based server)

Failure Logs

There are no errors related to this in the log file

Screenshot 2024-11-15 at 4 34 16 PM
Screenshot 2024-11-15 at 4 35 05 PM

@VivekShingala VivekShingala added bug Something isn't working unconfirmed Bug has not been reproduced yet labels Nov 15, 2024
@Ansari-techs
Copy link

I'm also facing this issue
Screenshot 2024-11-15 at 6 34 56 PM

@jsalguero94
Copy link

I hadn't seen this topic open and commented on it in the PR. #361 (comment)

@jsalguero94
Copy link

Hey, I just created a fix that works for me. I hope it can help you guys

#364

@enmaboya
Copy link
Contributor

enmaboya commented Nov 15, 2024

I commented in the pull request, the issue was actually something else.

At the moment, this problem can be easily solved by:

Publishing the resources with php artisan vendor:publish
Editing the file resources/views/vendor/shopify-app/auth/fullpage_redirect.blade.php
Then, remove line #7.

#365


Although in this case, both solutions are suitable, the result will be the same.

@VivekShingala
Copy link
Author

Hi @jsalguero94 and @enmaboya

Thank you for providing the quick fix. I tried with @enmaboya solution to remove a line from fullpage_redirect.blade.php and it worked.

Waiting for @Kyon147 to check and merge the PR and release it.

I will close this once the solution is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed Bug has not been reproduced yet
Projects
None yet
Development

No branches or pull requests

4 participants