-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set SNI's certificate ID ref #6660
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6660 +/- ##
=====================================
Coverage 77.6% 77.7%
=====================================
Files 201 200 -1
Lines 23766 23681 -85
=====================================
- Hits 18456 18402 -54
+ Misses 4359 4340 -19
+ Partials 951 939 -12 ☔ View full report in Codecov by Sentry. |
295aac0
to
750101a
Compare
750101a
to
7d4bcb6
Compare
Marking this as ready for review but this still requires feedback from Gateway team in the linked slack thread. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very interesting find 👀 I wasn't aware KIC sets IDs for Certificates. Apparently it does so from the beginning using Kubernetes Secret's UID. Let's see what the Gateway team says about the Consumers triggering SNIs with no Certificate ID rejected. 🤔
Anyway, I think we can merge this as an improvement.
Co-authored-by: Grzegorz Burzyński <[email protected]>
What this PR does / why we need it:
This PR adds SNI's certificate ID ref to be set in generated config. This basically means that instead of:
we generate
Which issue this PR fixes:
Fixes #6642
Special notes for your reviewer:
Related slack thread: https://kongstrong.slack.com/archives/C03CTMSHP6C/p1730991424228489
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR