chore: add more logs data when unparsable Gateway API error is received #6673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
added
the
area/maintenance
pmalek
force-pushed
the
logs-add-more-metadata-when-unparsable-gateway-error-occurs
branch
from
8094f6e
to
26427b1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6673 +/- ##
=======================================
+ Coverage 77.7% 80.1% +2.3%
=======================================
Files 202 203 +1
Lines 23798 23836 +38
=======================================
+ Hits 18497 19096 +599
+ Misses 4362 3775 -587
- Partials 939 965 +26 ☔ View full report in Codecov by Sentry. |
czeslavo
reviewed
Nov 14, 2024
Comment on lines
174
to
198
| if strings.HasPrefix(tag, util.K8sNameTagPrefix) { | ||
| re.Name = strings.TrimPrefix(tag, util.K8sNameTagPrefix) | ||
| continue | ||
| } | ||
| if strings.HasPrefix(tag, util.K8sNamespaceTagPrefix) { | ||
| re.Namespace = strings.TrimPrefix(tag, util.K8sNamespaceTagPrefix) | ||
| continue | ||
| } | ||
| if strings.HasPrefix(tag, util.K8sKindTagPrefix) { | ||
| gvk.Kind = strings.TrimPrefix(tag, util.K8sKindTagPrefix) | ||
| continue | ||
| } | ||
| if strings.HasPrefix(tag, util.K8sVersionTagPrefix) { | ||
| gvk.Version = strings.TrimPrefix(tag, util.K8sVersionTagPrefix) | ||
| continue | ||
| } | ||
| // this will not set anything for core resources | ||
| if strings.HasPrefix(tag, util.K8sGroupTagPrefix) { | ||
| gvk.Group = strings.TrimPrefix(tag, util.K8sGroupTagPrefix) | ||
| continue | ||
| } | ||
| if strings.HasPrefix(tag, util.K8sUIDTagPrefix) { | ||
| re.UID = strings.TrimPrefix(tag, util.K8sUIDTagPrefix) | ||
| continue | ||
| } |
There was a problem hiding this comment.
Maybe turning this into a switch would make sense, WDYT?
pmalek
force-pushed
the
logs-add-more-metadata-when-unparsable-gateway-error-occurs
branch
from
658281b
to
51b0ee4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This makes the
Entity tags missing fields {"name": "", "error": "no name"}errors, have a bit more context so that they are actually helpful in debugging:Related to #6660