fix(tests): don't use 2.x style path regex where requiring 3.x one

[pmalek]

What this PR does / why we need it:

This fixes the following deck warning:

time="2023-02-03T13:45:21+01:00" level=debug msg="converting configuration to deck config" kong_url="http://172.18.1.1:8001/"
1 unsupported routes' paths format with Kong version 3.0
or above were detected. Some of these routes are (not an exhaustive list):

18a19edb-0b01-4d9a-988b-146c3c086e04

Please upgrade your configuration to account for 3.0
breaking changes using the following command:

deck convert --from kong-gateway-2.x --to kong-gateway-3.x

This command performs the following changes:
  - upgrade the `_format_version` value to `3.0`
  - add the `~` prefix to all routes' paths containing a regex-pattern

These changes may not be correct or exhaustive enough.
It is strongly recommended to perform a manual audit
of the updated configuration file before applying
the configuration in production. Incorrect changes will result in
unintended traffic routing by Kong Gateway.

For more information about this and related changes,
please visit: https://docs.konghq.com/deck/latest/3.0-upgrade

updating route 8ec040df-5096-467e-b571-da89a2803a09.regex-toggle.httpbin..80  {
   "https_redirect_status_code": 426,
   "id": "18a19edb-0b01-4d9a-988b-146c3c086e04",
   "name": "8ec040df-5096-467e-b571-da89a2803a09.regex-toggle.httpbin..80",
   "path_handling": "v0",
   "paths": [
-    "~/test_ingress_class_regex_toggle/\d+"
+    "/test_ingress_class_regex_toggle/\d+"
   ],
   "preserve_host": true,
   "protocols": [
     "http",
     "https"
   ],
   "regex_priority": 0,
   "request_buffering": true,
   "response_buffering": true,
   "service": {
     "id": "1f195e3d-4b76-4b27-b03b-14c69f84f02d",
     "name": "8ec040df-5096-467e-b571-da89a2803a09.regex-toggle.httpbin.80"
   },
   "strip_path": true,
   "tags": [
     "managed-by-ingress-controller"
   ]
 }

Sadly there's no way to check/assert this now (or is there?). Perhaps we could introduce event for deck conversion warning/errors? 🤔

[codecov]

Codecov Report

Base: 73.9% // Head: 73.8% // Decreases project coverage by -0.1% ⚠️

Coverage data is based on head (30361d2) compared to base (65e07cf).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #3489     +/-   ##
=======================================
- Coverage   73.9%   73.8%   -0.1%     
=======================================
  Files        118     118             
  Lines      13990   13990             
=======================================
- Hits       10341   10335      -6     
- Misses      2987    2992      +5     
- Partials     662     663      +1     

Impacted Files	Coverage Δ
internal/dataplane/parser/translate_utils.go	88.9% <0.0%> (-5.6%)	⬇️
...nternal/controllers/gateway/tlsroute_controller.go	71.4% <0.0%> (-2.1%)	⬇️
...nternal/controllers/gateway/udproute_controller.go	71.6% <0.0%> (+2.1%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pmalek]

No warnings in https://github.com/Kong/kubernetes-ingress-controller/actions/runs/4103308328/jobs/7077329430 CI run.

[czeslavo]

Sadly there's no way to check/assert this now (or is there?). Perhaps we could introduce event for deck conversion warning/errors? 🤔

That would be similar to #3205, but for deck. The mentioned issue explicitly states that adapting the deck is out of scope. I allowed myself to create an issue that will track deck's side: #3492.