Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestIngressClassRegexToggle outputs deck notice that it shouldn't(?) #3482

Closed
1 task done
pmalek opened this issue Feb 3, 2023 · 0 comments · Fixed by #3489
Closed
1 task done

TestIngressClassRegexToggle outputs deck notice that it shouldn't(?) #3482

pmalek opened this issue Feb 3, 2023 · 0 comments · Fixed by #3489
Assignees
Labels
bug Something isn't working

Comments

@pmalek
Copy link
Member

pmalek commented Feb 3, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When running TestIngressClassRegexToggle in isolation in dbmode=postgres like so:

make test.integration.postgres GOTESTFLAGS="-count 1 -run TestIngressClassRegexToggle"

one can reliably notice the following note from deck

time="2023-02-03T13:45:21+01:00" level=debug msg="converting configuration to deck config" kong_url="http://172.18.1.1:8001/"
1 unsupported routes' paths format with Kong version 3.0
or above were detected. Some of these routes are (not an exhaustive list):

18a19edb-0b01-4d9a-988b-146c3c086e04

Please upgrade your configuration to account for 3.0
breaking changes using the following command:

deck convert --from kong-gateway-2.x --to kong-gateway-3.x

This command performs the following changes:
  - upgrade the `_format_version` value to `3.0`
  - add the `~` prefix to all routes' paths containing a regex-pattern

These changes may not be correct or exhaustive enough.
It is strongly recommended to perform a manual audit
of the updated configuration file before applying
the configuration in production. Incorrect changes will result in
unintended traffic routing by Kong Gateway.

For more information about this and related changes,
please visit: https://docs.konghq.com/deck/latest/3.0-upgrade

updating route 8ec040df-5096-467e-b571-da89a2803a09.regex-toggle.httpbin..80  {
   "https_redirect_status_code": 426,
   "id": "18a19edb-0b01-4d9a-988b-146c3c086e04",
   "name": "8ec040df-5096-467e-b571-da89a2803a09.regex-toggle.httpbin..80",
   "path_handling": "v0",
   "paths": [
-    "~/test_ingress_class_regex_toggle/\d+"
+    "/test_ingress_class_regex_toggle/\d+"
   ],
   "preserve_host": true,
   "protocols": [
     "http",
     "https"
   ],
   "regex_priority": 0,
   "request_buffering": true,
   "response_buffering": true,
   "service": {
     "id": "1f195e3d-4b76-4b27-b03b-14c69f84f02d",
     "name": "8ec040df-5096-467e-b571-da89a2803a09.regex-toggle.httpbin.80"
   },
   "strip_path": true,
   "tags": [
     "managed-by-ingress-controller"
   ]
 }

Expected Behavior

No notes from deck are reported.

Steps To Reproduce

1. run `make test.integration.postgres GOTESTFLAGS="-count 1 -run TestIngressClassRegexToggle"`
1. observe `deck` note

Kong Ingress Controller version

No response

Kubernetes version

f1793b777f2905cbcc193cb0291a6027251535cb

Anything else?

No response

@pmalek pmalek added the bug Something isn't working label Feb 3, 2023
@pmalek pmalek self-assigned this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant