fix: detect filter chain support from API response #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the business logic that is used to decide if (wasm) filter chains are supported by Kong. Instead of relying on the caller to set `dump.Config.IsFilterChainsSupported`, we check the error response code from `GET /filter-chains` and decide how to proceed from there.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 41.18% 41.16% -0.02%
==========================================
Files 74 74
Lines 10802 10807 +5
==========================================
Hits 4449 4449
- Misses 5891 5896 +5
Partials 462 462 ☔ View full report in Codecov by Sentry. |
GGabriele
approved these changes
Jun 7, 2024
pmalek
reviewed
Jun 7, 2024
| return nil | ||
| }) | ||
| } else { | ||
| group.Go(func() error { | ||
| state.FilterChains = make([]*kong.FilterChain, 0) |
There was a problem hiding this comment.
We don't really need to set this here and allocate the slice, right?
Line 271 will do I guess.
There was a problem hiding this comment.
You're right--we don't strictly need to allocate here. I thought it better to have the "set a default value" code at the top rather than hiding it 3 levels deep in the "we got an error, but it's okay" branch, but I have no objections to moving it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the business logic that is used to decide if (wasm) filter chains are supported by Kong. Instead of relying on the caller to set
dump.Config.IsFilterChainsSupported, we check the error response code fromGET /filter-chainsand decide how to proceed from there.See also: Kong/deck#987 specifically: Kong/deck#987 (comment)
KAG-4005