-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add wasm filter-chain entity support #987
Conversation
9b72eaf
to
fe5e0bc
Compare
a84e1ea
to
f9c3ca5
Compare
See also: Kong/go-database-reconciler#72 |
f9c3ca5
to
3b9a749
Compare
3b9a749
to
08a2be1
Compare
fc9da65
to
071d975
Compare
Edit: both of these are done. |
907e29f
to
b6dbadd
Compare
f88707c
to
9f2c566
Compare
re:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
==========================================
- Coverage 22.49% 22.39% -0.10%
==========================================
Files 54 54
Lines 4508 4514 +6
==========================================
- Hits 1014 1011 -3
- Misses 3395 3403 +8
- Partials 99 100 +1 ☔ View full report in Codecov by Sentry. |
👋 @GGabriele do you think you could review or help source a reviewer for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please add some integration tests too?
Okay, found another wart in testing. PR for fixage his here: |
Okay, Kong/go-database-reconciler#101 has been merged, but we're blocked on getting a version bump. I've also submitted a semi-related bugfix PR to gdr (link). I think it would be wise to merge this before the version bump so that it is included with filter chain support from the get-go. |
@GGabriele sorry for the turnaround time. This is ready for another round of review. Let me know what you think of the integration tests--anything else that you think would particularly benefit from more coverage? |
@flrgh a new version of go-database-reconciler has been released now. |
7b49f79
to
c2c5289
Compare
@GGabriele Awesome! Bumped and added test coverage. |
This brings support for wasm filter chains to deck.
Most of the groundwork for this was laid in the other repos:
Wasm filters were added in 3.4 and are an optional feature.
Feature detection in deck works by fetching the root admin API endpoint and inspecting the configuration to see ifEDIT: Feature detection works by callingwasm
is enabled (this works for versions <3.4 and versions >=3.4 with wasm disabled). Feature detection does not run in Konnect mode; therefore Konnect is not yet supported, only Kong gateway OSS/EEGET /filter-chains
and inspecting the response code (link).For the sake of keeping things reasonable in size (we're at >3k new lines of code if you include the other 2 PRs), there are some validation steps that have been left out:
These things are of course still validated by the Kong admin API, but at a later date it will be possible to validate them client-side for better UX.
KAG-4005
KOKO-1275