Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up portfolio page #73

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Clean up portfolio page #73

merged 6 commits into from
Oct 10, 2023

Commits on Oct 10, 2023

  1. Simplify “Add Coin” button into a FAB

    @CharlVS
    CharlVS committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    9e9d2e7 View commit details
    Browse the repository at this point in the history

  2. Rename “Add Coin” fab file name

    @CharlVS
    CharlVS committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    ac6a6ce View commit details
    Browse the repository at this point in the history

  3. Simplify portfolio page to fit more coins 

    - Simplify coin items to reduce height and fit more coins on the portfolio page.

- Replace the “Add Coins” sliver button with a plus icon FAB.

- Simplify the assets proportion graph and move to a separate file.

- Reduce unnecessary builds for the coins list on the coins page. It defeats the purpose of using a ListView builder if it is wrapped in a scrollable widget with `softWrap = true` that makes it render all its children.

- Minor code formatting changes.
    @CharlVS
    CharlVS committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    17cc28b View commit details
    Browse the repository at this point in the history

  4. Correct [AnimatedAssetProportionsBarGraph] docsa 

    Fix a minor mistake in the widget [AnimatedAssetProportionsBarGraph]’s API documentation.
    @CharlVS
    CharlVS committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    18a2421 View commit details
    Browse the repository at this point in the history

  5. Don’t clip square coin icons on portfolio page 

    Some coin icons are square/rectangular (e.g. PANDA). Previously, it would crop it to a circle shape
    @CharlVS
    CharlVS committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    76822bc View commit details
    Browse the repository at this point in the history

  6. Animated asset proportion graph tweaks

    @CharlVS
    CharlVS committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    63dac73 View commit details
    Browse the repository at this point in the history