Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up portfolio page #73

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Clean up portfolio page #73

merged 6 commits into from
Oct 10, 2023

Conversation

CharlVS
Copy link
Member

@CharlVS CharlVS commented Oct 9, 2023 •
edited
Loading

Changelog:

  • Simplify the main coins portfolio page to fit more coins in the same height.
  • Make assets bar graph animate.

To test:

  • Long list of coins shows correctly.
  • User can toggle displayed currency mode (tap icon button next to balance in top bar).
  • Test that the asset bar graph animates when balances change.

image

@CharlVS CharlVS added the QA Ready for QA testing label Oct 9, 2023
@CharlVS CharlVS self-assigned this Oct 9, 2023
naezith
naezith previously approved these changes Oct 9, 2023
View reviewed changes
kivqa
kivqa approved these changes Oct 9, 2023
View reviewed changes
Copy link

@kivqa kivqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
Long list displayed correctly.
Currency switcher work as expected.
Animations work as expected.
Tested on Android 13 device

@CharlVS
Simplify “Add Coin” button into a FAB
9e9d2e7
@CharlVS
Rename “Add Coin” fab file name
ac6a6ce
@CharlVS
Simplify portfolio page to fit more coins
17cc28b 
- Simplify coin items to reduce height and fit more coins on the portfolio page.

- Replace the “Add Coins” sliver button with a plus icon FAB.

- Simplify the assets proportion graph and move to a separate file.

- Reduce unnecessary builds for the coins list on the coins page. It defeats the purpose of using a ListView builder if it is wrapped in a scrollable widget with `softWrap = true` that makes it render all its children.

- Minor code formatting changes.
@CharlVS
Correct [AnimatedAssetProportionsBarGraph] docsa
18a2421 
Fix a minor mistake in the widget [AnimatedAssetProportionsBarGraph]’s API documentation.
@CharlVS
Don’t clip square coin icons on portfolio page
76822bc 
Some coin icons are square/rectangular (e.g. PANDA). Previously, it would crop it to a circle shape
@CharlVS
Animated asset proportion graph tweaks
63dac73
@CharlVS CharlVS merged commit 796d992 into dev Oct 10, 2023
1 check failed
@CharlVS CharlVS deleted the add/clean-up-portfolio-page branch October 10, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kivqa kivqa kivqa approved these changes

@naezith naezith naezith left review comments

@ca333 ca333 Awaiting requested review from ca333

Assignees

@CharlVS CharlVS

Labels
QA Ready for QA testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CharlVS @naezith @kivqa