Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui_auth -> komodo_proxy #1162

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

gui_auth -> komodo_proxy #1162

wants to merge 3 commits into from

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Nov 1, 2024 •
edited
Loading

ref: KomodoPlatform/komodo-docs-mdx#318 (comment)

In the next KDF release, the gui_auth param has been renamed to komodo_proxy. This PR updates the coins info accordingly so the "coins_config.json" files reflect the change.

@CharlVS this may affect the web wallet if not already handled.

@smk762 smk762 changed the title gui_auth -> komodo_auth gui_auth -> komodo_proxy Nov 1, 2024
cipig
cipig approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in my repo and works fine
just be careful with the conflict in utils/generate_app_configs.py when merging... collision comes from the removed electrum-limit of 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipig cipig cipig approved these changes

@gcharang gcharang Awaiting requested review from gcharang

@CharlVS CharlVS Awaiting requested review from CharlVS

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smk762 @cipig