Fix execution caching to cache artifact graph NodePath #6978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Instrumentation Performance ReportMerging #6978 will not alter performanceComparing Summary
|
jtran
force-pushed
the
jtran/fix-empty-artifact-graph
branch
from
9b94acb to
ed7cafe
Compare
Irev-Dev
approved these changes
May 15, 2025
Comment on lines
+262
to
+268
| profile001 = startProfile(sketch001, at = [5.5, 5.25]) | ||
| |> line(end = [10.5, -1.19]) | ||
| |> line(end = [8, -5.5]) | ||
| |> line(end = [-1.02, -6.76]) | ||
| |> line(end = [-11.5, 2.8]) | ||
| |> close() | ||
| plane001 = offsetPlane(XY, offset = 20) |
There was a problem hiding this comment.
Why did the input kcl need to change?
There was a problem hiding this comment.
oh
The sim test output is from fixing SketchOnFace and SketchOnPlane, just something I noticed was broken while investigating this.
never mind
There was a problem hiding this comment.
The reason I used offsetPlane() was because I wanted to have something to refer to in the second execution, like in way we reproduced #6841.
The coordinate changes were arbitrary. Just wanted rounder numbers to look at.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6841. Replaces/closes #6885.
The cache test is the critical one that proves we fix #6841. Before, we were actually rebuilding the whole graph from commands each time. Now, when it's cached, we start from the cached graph.
The sim test output is from fixing SketchOnFace and SketchOnPlane, just something I noticed was broken while investigating this.