Fix to add NodePaths to SketchOnFace and SketchOnPlane artifacts #6885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Instrumentation Performance ReportMerging #6885 will not alter performanceComparing Summary
|
jtran
force-pushed
the
jtran/fix-sketch-on-face-node-path
branch
from
439d22d to
352a2fa
Compare
Irev-Dev
approved these changes
May 13, 2025
jtran
force-pushed
the
jtran/node-path-output
branch
from
36398db to
c50391c
Compare
jtran
force-pushed
the
jtran/fix-sketch-on-face-node-path
branch
from
352a2fa to
6c9f39e
Compare
|
I have an improved way to do this, and I'm going to roll it into #6978. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #6884 so that we can see the fix is working.
The "Missing NodePath"s that are left are all SourceRanges pointing into another module.