fix: symbol replace text box dark mode contrast (#6827) #6899
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @rajgandhi1, thanks so much for the PR. I recreated it at #6927 with a branch on origin so we can get the CI to green and merge your commit! |
|
cc @franknoirot |
rajgandhi1
force-pushed
the
fix/6827-symbol-replace-dark-mode
branch
from
763e647 to
c89ca85
Compare
|
@pierremtb I have made the correct changes now. Have tested it as well. |
|
@rajgandhi1 oh thanks! I take it you were able to run the app locally? |
|
@pierremtb yes I was able to set it up and run locally. Thanks |
src/index.css
Outdated
| .cm-rename-popup input { | ||
| color: black !important; | ||
| background: white !important; | ||
| } | ||
|
|
There was a problem hiding this comment.
Ok so both in dark and light mode we have this input black text on white background yes? Might want to add a quick comment in there that mentions that maybe?
There was a problem hiding this comment.
yes. added the comments
|
Ok great, I made #6927 ready for review with your last change and will seek an approval from the frontend team before we merge. Thanks so much @rajgandhi1! I'll let you know when it lands so we can close this one. |
|
Sure. @pierremtb thanks for your help. |
|
#6927 merged! Closing this one now. |
No description provided.