Skip to content

Symbol replace text box is white text on white background in dark mode #6827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
franknoirot opened this issue May 10, 2025 · 1 comment · Fixed by #6927
Closed

Symbol replace text box is white text on white background in dark mode #6827

franknoirot opened this issue May 10, 2025 · 1 comment · Fixed by #6927
Labels
bug Something isn't working low-priority polish

Comments

@franknoirot
Copy link
Contributor

Image

Wow it's cool to have this feature though, first time I've used it.
@franknoirot franknoirot added bug Something isn't working low-priority polish labels May 10, 2025
@rajgandhi1
Copy link
Contributor

rajgandhi1 commented May 13, 2025 •
edited
Loading

https://github.com/KittyCAD/modeling-app/pull/6899

@pierremtb pierremtb mentioned this issue May 14, 2025
Merged
rajgandhi1 added a commit to rajgandhi1/modeling-app that referenced this issue May 15, 2025
@rajgandhi1
correct fix for rename popup white text on white background KittyCAD#…
763e647 
…6827
rajgandhi1 added a commit to rajgandhi1/modeling-app that referenced this issue May 15, 2025
@rajgandhi1
fix: symbol replace text box dark mode contrast (KittyCAD#6827)
cbc2df9
rajgandhi1 added a commit to rajgandhi1/modeling-app that referenced this issue May 15, 2025
@rajgandhi1
correct fix for rename popup white text on white background KittyCAD#…
c89ca85 
…6827
pierremtb added a commit that referenced this issue May 15, 2025
@pierremtb
correct fix for rename popup white text on white background #6827
d3e3ab3
pierremtb added a commit that referenced this issue May 15, 2025
@pierremtb @rajgandhi1
External: Fix: symbol replace text box dark mode contrast (#6827) (#6927
2be7107 
)

* fix: symbol replace text box dark mode contrast (#6827)

* fix: symbol replace text box dark mode contrast (#6827)

* correct fix for rename popup white text on white background #6827

* correct fix for rename popup white text on white background #6827

* added comments explaining the change

---------

Co-authored-by: rajgandhi1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working low-priority polish
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

External: Fix: symbol replace text box dark mode contrast (#6827) KittyCAD/modeling-app
2 participants
@franknoirot @rajgandhi1