Update getSketchExprsFromSelection to use codeRef.pathToNode #6737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pierremtb
commented
May 7, 2025
| const sketchVariable = getNodeFromPath<VariableDeclarator>( | ||
| ast, | ||
| path, | ||
| s?.codeRef.pathToNode, |
There was a problem hiding this comment.
@Irev-Dev Mmmmh this change did break some of our sweep tests https://github.com/KittyCAD/modeling-app/actions/runs/14884043507/job/41798886884?pr=6737
There was a problem hiding this comment.
@jtran @Irev-Dev the tests that broke up there were in edit steps
Related https://github.com/KittyCAD/modeling-app/pull/6963/files#r2090752944
There was a problem hiding this comment.
Looks like we're back to green after 7030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a follow up from #6437
Part of #6650.