Make sweep tests more point-and-click like and clean up pathToNode retrieval #6963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pierremtb
commented
May 15, 2025
Comment on lines
-140
to
+142
| const pathNodePath = getNodePathFromSourceRange( | ||
| ast, | ||
| path.graphSelections[0].codeRef.range | ||
| ) | ||
| // Find the path declaration for the labeled argument | ||
| const pathDeclaration = getNodeFromPath<VariableDeclaration>( | ||
| ast, | ||
| pathNodePath, | ||
| path.graphSelections[0].codeRef.pathToNode, |
There was a problem hiding this comment.
@Irev-Dev @jtran I was playing with this as I remember you telling me to start trusting codeRef.pathToNode more. This change away from getNodePathFromSourceRange works perfectly for me when I'm creating a sweep, but not if I'm editing one. Just a data point, I can help investigate whenever
Related https://github.com/KittyCAD/modeling-app/pull/6737/files#r2077656349
…-picking-the-wrong-profile-variable
…-picking-the-wrong-profile-variable
pierremtb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #6952
Part of #6650.