Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add FT5HN and FT5HV #2754

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Add FT5HN and FT5HV #2754

merged 3 commits into from
Sep 24, 2020

Conversation

bitglue
Copy link
Contributor

@bitglue bitglue commented May 25, 2020

Datasheet: https://www.mouser.com/datasheet/2/160/T5HN_T5HV-1662393.pdf

Footprint: KiCad/kicad-footprints#2293
3D model: KiCad/kicad-packages3D#699
3D model source: KiCad/kicad-packages3D-source#282

image

image

image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@CLAassistant
Copy link

CLAassistant commented May 25, 2020

CLA assistant check
All committers have signed the CLA.

@bitglue bitglue force-pushed the FT5HN branch 3 times, most recently from dc7f865 to 4f4e5f7 Compare May 25, 2020 16:18
@bitglue
Copy link
Contributor Author

bitglue commented May 25, 2020

Travis is failing just because the footprint doesn't exist, which will be resolved by KiCad/kicad-footprints#2293

@aewallin
Copy link
Contributor

For FT5HN, could you stack the two GND pins?

if you look at the existing oscillator symbols they seem to have a square or sine waveform drawn inside the symbol - consider that.

mouser is probably not the original datasheet source? is there an alternative link from the manufacturer?

@bitglue
Copy link
Contributor Author

bitglue commented May 27, 2020 via email

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels May 27, 2020
@bitglue
Copy link
Contributor Author

bitglue commented Jun 5, 2020

@aewallin thanks for the review, changes made:

  • changed datasheet links to go to foxonline.com
  • stacked GND pins
  • added square-wavey symbol

@bitglue
Copy link
Contributor Author

bitglue commented Jul 24, 2020

@aewallin any more changes requested?

@myfreescalewebpage myfreescalewebpage self-assigned this Jul 28, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Jul 28, 2020
@myfreescalewebpage
Copy link
Collaborator

Closing/opening to refresh the Travis test.

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Jul 28, 2020

Hello @bitglue and thanks @aewallin for the first steps of the review

Complete review of the symbols:

FT5HN

  • The footprint filter should be Oscillator*SMD*Fox*FT5H*5.0x3.2mm*
  • Incorrect GND pin stacking (see travis error)

FT5HV

  • The footprint filter should be Oscillator*SMD*Fox*FT5H*5.0x3.2mm*

Else, just need to wait the footprint

Joel

@myfreescalewebpage
Copy link
Collaborator

@bitglue ping

@myfreescalewebpage myfreescalewebpage added the Pending footprint Pending footprint acceptance before merging label Aug 24, 2020
@myfreescalewebpage
Copy link
Collaborator

No news of the original author, indicate the PR is abandoned.

@myfreescalewebpage myfreescalewebpage added the Abandoned Original author has stopped working on the PR label Aug 24, 2020
@bitglue
Copy link
Contributor Author

bitglue commented Sep 16, 2020

@myfreescalewebpage rebump

@myfreescalewebpage myfreescalewebpage removed the Abandoned Original author has stopped working on the PR label Sep 16, 2020
@myfreescalewebpage
Copy link
Collaborator

Thanks, just need to wait the footprint now.

@bitglue
Copy link
Contributor Author

bitglue commented Sep 24, 2020

@myfreescalewebpage footprint has been merged. There are also 3D models, not sure who to ping on those since there haven't been any comments yet:

KiCad/kicad-packages3D-source#282
KiCad/kicad-packages3D#699

Also I have some 3D models for a different component, if you could nudge them along I'd appreciate it:

KiCad/kicad-packages3D-source#281
KiCad/kicad-packages3D#698

@myfreescalewebpage myfreescalewebpage removed the Pending footprint Pending footprint acceptance before merging label Sep 24, 2020
@myfreescalewebpage
Copy link
Collaborator

Thanks to ping me on this, no more comment and merging.

For the packages 3D we are not a lot to be confortable with the review, this may take more time.

@myfreescalewebpage myfreescalewebpage merged commit 751de72 into KiCad:master Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants