-
Notifications
You must be signed in to change notification settings - Fork 713
Add Oscillator_SMD_Fox_FT5H_5.0x3.2mm #2293
Add Oscillator_SMD_Fox_FT5H_5.0x3.2mm #2293
Conversation
05072b4
to
7987567
Compare
I have a symbol too, will submit in a bit. |
Please do not use the mouser datasheet. Point to the datasheet directly via the manufacturers website |
silk-lines look like they are hidden under the part? (see KLC F5.1.4. "no silkscreen allowed under component") |
They follow the outline. You want them set out? By how much?
…On Tue, May 26, 2020, 11:14 Anders Wallin ***@***.***> wrote:
silk-lines look like they are hidden under the part? (see KLC F5.1.4. "no
silkscreen allowed under component")
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2293 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJM4WAL76IASNAPAPPE6MDRTQAUTANCNFSM4NGONANA>
.
|
There is no exact guideline for how much silk-screen should be outside the outline of the part, just that silk should not be under the (SMD) component. I guess one line-width is enough of a gap between the outline and the silk. |
7987567
to
acde8bb
Compare
a874080
to
959e107
Compare
Hi @bitglue , i will start reviewing this PR now, i want to ask, please do not force-push from now on. I will comment again when i am done. Thank you for your contribution. Best regards, |
Hi @bitglue , are you willing to continue with this PR? Sorry for short notice pinging. Things changing fast and it is good to merge this as it is a full symbol addition with symbol footprint and 3d model.. |
rotated the footprint, i'll try to do the 3d model tonight |
It would be so nice if the rule checker was embedded in the footprint editor. |
Yes i thought of it too, but i learnt that it rounds numbers so it is not adviced to use it for reviewing... I will review this a little later. Thanks for acting fast :) |
I could have messed up the rotation. And it occurs to me I have evening plans, so probably won't get to this and the footprint tonight. Should be able to get to everything this weekend though, if not sooner. |
@chschlue , is there a rule about handsolder pad dimmensions or this can be custom per creator/part? @bitglue , Select all, and move excactly x: For the second part, since i saw it hasn't moved. With less steps: Previous steps mostly will help to center a lost footprint also with consulting datasheet drawings. Hope this helped. |
No, it's basically arbitrary. But (for perspective) the recommended pads are larger than a whole 0603 package, is a special hand soldering variant necessary @bitglue? |
776b34f
to
acd7818
Compare
acd7818
to
d2a562b
Compare
@chschlue with the pads on the bottom it's kind of a tricky thing to hand solder with any footprint. I don't think the bigger pads would make it significantly easier, so I just ditched that footprint. |
@aris-kimi @chschlue Any more changes required? |
No @bitglue , looks good. |
Datasheet: https://www.mouser.com/datasheet/2/160/T5HN_T5HV-1662393.pdf
Symbol: KiCad/kicad-symbols#2754
3D model: KiCad/kicad-packages3D#699
3D model source: KiCad/kicad-packages3D-source#282
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)