Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Oscillator_SMD_Fox_FT5H_5.0x3.2mm #2293

Merged
merged 3 commits into from
Sep 24, 2020

Conversation

bitglue
Copy link
Contributor

@bitglue bitglue commented May 21, 2020

Datasheet: https://www.mouser.com/datasheet/2/160/T5HN_T5HV-1662393.pdf

Symbol: KiCad/kicad-symbols#2754
3D model: KiCad/kicad-packages3D#699
3D model source: KiCad/kicad-packages3D-source#282

image

image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@CLAassistant
Copy link

CLAassistant commented May 21, 2020

CLA assistant check
All committers have signed the CLA.

@bitglue bitglue force-pushed the Oscillator_SMD_Fox_FT5H_5.0x3.2mm branch 3 times, most recently from 05072b4 to 7987567 Compare May 21, 2020 01:42
@bitglue
Copy link
Contributor Author

bitglue commented May 21, 2020

I have a symbol too, will submit in a bit.

@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels May 23, 2020
@poeschlr
Copy link
Collaborator

Please do not use the mouser datasheet. Point to the datasheet directly via the manufacturers website

@aewallin
Copy link
Contributor

silk-lines look like they are hidden under the part? (see KLC F5.1.4. "no silkscreen allowed under component")

@bitglue
Copy link
Contributor Author

bitglue commented May 27, 2020 via email

@aewallin
Copy link
Contributor

There is no exact guideline for how much silk-screen should be outside the outline of the part, just that silk should not be under the (SMD) component. I guess one line-width is enough of a gap between the outline and the silk.

@bitglue bitglue force-pushed the Oscillator_SMD_Fox_FT5H_5.0x3.2mm branch from 7987567 to acde8bb Compare June 5, 2020 15:36
@bitglue
Copy link
Contributor Author

bitglue commented Jun 5, 2020

@poeschlr @aewallin thanks for the reviews. Changes made:

  • offset the silk lines so they are fully visible under the package
  • added a HandSoldering variant, with the pads 0.5mm larger
  • changed link to datasheet from foxonline.com

@bitglue
Copy link
Contributor Author

bitglue commented Jun 5, 2020

Updated footprint:

fox

HandSoldering variant:

fox_handsoldering

@bitglue bitglue force-pushed the Oscillator_SMD_Fox_FT5H_5.0x3.2mm branch 2 times, most recently from a874080 to 959e107 Compare June 5, 2020 15:44
@aris-kimi aris-kimi self-assigned this Aug 22, 2020
@aris-kimi aris-kimi removed the Pending reviewer A pull request waiting for a reviewer label Aug 22, 2020
@aris-kimi
Copy link
Collaborator

Hi @bitglue , i will start reviewing this PR now, i want to ask, please do not force-push from now on. I will comment again when i am done.

Thank you for your contribution.

Best regards,
Aris

@aris-kimi
Copy link
Collaborator

aris-kimi commented Aug 22, 2020

  • KLC F4.2 Pin 1 should be located at the top left
    So orientation needs to change to both parts.

All dimmensions seemed good. I didn't catch anything else.

εικόνα

@aris-kimi
Copy link
Collaborator

Hi @bitglue , are you willing to continue with this PR? Sorry for short notice pinging. Things changing fast and it is good to merge this as it is a full symbol addition with symbol footprint and 3d model..

@bitglue
Copy link
Contributor Author

bitglue commented Aug 26, 2020

rotated the footprint, i'll try to do the 3d model tonight

@bitglue
Copy link
Contributor Author

bitglue commented Aug 26, 2020

It would be so nice if the rule checker was embedded in the footprint editor.

@aris-kimi
Copy link
Collaborator

aris-kimi commented Aug 26, 2020

Yes i thought of it too, but i learnt that it rounds numbers so it is not adviced to use it for reviewing... I will review this a little later. Thanks for acting fast :)

@bitglue
Copy link
Contributor Author

bitglue commented Aug 26, 2020

I could have messed up the rotation. And it occurs to me I have evening plans, so probably won't get to this and the footprint tonight. Should be able to get to everything this weekend though, if not sooner.

@aris-kimi
Copy link
Collaborator

aris-kimi commented Aug 27, 2020

@chschlue , is there a rule about handsolder pad dimmensions or this can be custom per creator/part?

@bitglue ,
np. I gave it a look, yes it is a little messed.

Select all, and move excactly x: 0.037443 y: -0.012557
Applies to Oscillator_SMD_Fox_FT5H_5.0x3.2mm.

For the second part, since i saw it hasn't moved.
My strategy is:
note down pin1 coordinates,
select all,
move excactly as (current pin1 coordinates noted) * -1 in order to locate this pin to 0,0 (with all selection moved),
(i think * -1 applies, i allways check my cursor coordinates since current KiCAD's coordinate counting confuses me..)
select a high grid and confirm pin 1(with whole selection) has moved correct,
now selet all once again and rotate,
(better if you keep your cursor at 0.0 after selection and before rotation applied)
fit pin 1 at 0.0 point with the cursor,
confirm pin1 once again and select all,
final move excactly all selection to noted pin1 coordinates with all negative values but in reversed fields(x-y),
final confirm.

With less steps:
start with a high number grid step,
select all,
fit your cursor to 0.0,
apply rotation as many times needed,
final confirm.

Previous steps mostly will help to center a lost footprint also with consulting datasheet drawings.

Hope this helped.

@chschlue
Copy link
Contributor

No, it's basically arbitrary.

But (for perspective) the recommended pads are larger than a whole 0603 package, is a special hand soldering variant necessary @bitglue?

@bitglue bitglue force-pushed the Oscillator_SMD_Fox_FT5H_5.0x3.2mm branch from 776b34f to acd7818 Compare September 14, 2020 00:55
@bitglue bitglue force-pushed the Oscillator_SMD_Fox_FT5H_5.0x3.2mm branch from acd7818 to d2a562b Compare September 14, 2020 01:00
@bitglue
Copy link
Contributor Author

bitglue commented Sep 14, 2020

Fixed the rotation, and updated the 3d model
image

@bitglue
Copy link
Contributor Author

bitglue commented Sep 16, 2020

@chschlue with the pads on the bottom it's kind of a tricky thing to hand solder with any footprint. I don't think the bigger pads would make it significantly easier, so I just ditched that footprint.

@bitglue
Copy link
Contributor Author

bitglue commented Sep 21, 2020

@aris-kimi @chschlue Any more changes required?

@aris-kimi
Copy link
Collaborator

No @bitglue , looks good.
Merging now.
Thank you for your contribution.

@aris-kimi aris-kimi merged commit 83cd4d9 into KiCad:master Sep 24, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 6.0.0 milestone Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants