Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chassis: Fix ReleaseValidationObject() #9470

Closed
wants to merge 1 commit into from
Closed

chassis: Fix ReleaseValidationObject() #9470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions layers/chassis/dispatch_object.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

#pragma once
#include <atomic>
#include <list>

#include <vulkan/vulkan.h>
#include <vulkan/vk_enum_string_helper.h>
Expand Down Expand Up @@ -232,7 +233,7 @@ class Instance : public HandleWrapper {
APIVersion api_version;
DeviceExtensions extensions{};

mutable std::vector<std::unique_ptr<base::Instance>> object_dispatch;
mutable std::list<std::unique_ptr<base::Instance>> object_dispatch;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::list is a rare guest, maybe a comment why we use it.


VkInstance instance = VK_NULL_HANDLE;
VkLayerInstanceDispatchTable instance_dispatch_table;
Expand Down Expand Up @@ -293,9 +294,9 @@ class Device : public HandleWrapper {
VkDevice device = VK_NULL_HANDLE;
VkLayerDispatchTable device_dispatch_table;

mutable std::vector<std::unique_ptr<base::Device>> object_dispatch;
mutable std::vector<std::unique_ptr<base::Device>> aborted_object_dispatch;
mutable std::vector<std::vector<base::Device*>> intercept_vectors;
mutable std::list<std::unique_ptr<base::Device>> object_dispatch;
mutable std::list<std::unique_ptr<base::Device>> aborted_object_dispatch;
mutable std::vector<std::list<base::Device*>> intercept_vectors;
// Handle Wrapping Data
// Wrapping Descriptor Template Update structures requires access to the template createinfo structs
vvl::unordered_map<uint64_t, std::unique_ptr<TemplateState>> desc_template_createinfo_map;
Expand Down
Loading