chassis: Fix ReleaseValidationObject() #9470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 374349. |
|
CI Vulkan-ValidationLayers build # 19097 running. |
GPU-AV can detect problems and remove itself from object_dispatch and intercept_vectors. Make these lists rather than vectors so that removal doesn't invalidate iterators. Removal can happen during the FinishDeviceSetup() loop or possibly any other vulkan call. GPU-AV is not the last entry in these lists and calls still need to happen for anything after it (currently only syncval), so playing games with vector indexing will not work. Fixes KhronosGroup#9412
jeremyg-lunarg
force-pushed
the
jeremyg-issue-9412
branch
from
ea2d53f to
8505cee
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 374399. |
artem-lunarg
approved these changes
Feb 18, 2025
| @@ -232,7 +233,7 @@ class Instance : public HandleWrapper { | |||
| APIVersion api_version; | |||
| DeviceExtensions extensions{}; | |||
|
|
|||
| mutable std::vector<std::unique_ptr<base::Instance>> object_dispatch; | |||
| mutable std::list<std::unique_ptr<base::Instance>> object_dispatch; | |||
There was a problem hiding this comment.
std::list is a rare guest, maybe a comment why we use it.
|
CI Vulkan-ValidationLayers build # 19098 running. |
arno-lunarg
requested changes
Feb 18, 2025
|
I think the fix from my PR now updated to manage the issues Artem should work, but the for loop update needs to be propagated to every functions -_- auto& object_dispatches = vvl::dispatch::GetData(*pDevice)->object_dispatch;
for (int32_t i = 0; i < object_dispatches.size(); ++i) {
auto& vo = object_dispatches[i];
vo->FinishDeviceSetup(modified_create_info.ptr(), record_obj.location);
if (!object_dispatches[i]) {
--i;
}
}But that assumes that GPU-AV unique pointers only gets nulled, not actually removed. So maybe we need to go: auto& object_dispatches = vvl::dispatch::GetData(*pDevice)->object_dispatch;
for (int32_t i = 0; i < object_dispatches.size(); ++i) {
auto& vo = object_dispatches[i];
const size_t tmp_size = object_dispatches.size();
vo->FinishDeviceSetup(modified_create_info.ptr(), record_obj.location);
if ( tmp_size != object_dispatches.size()) {
--i;
}
} |
|
CI Vulkan-ValidationLayers build # 19098 failed. |
|
yes this approach won't work either. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPU-AV can detect problems and remove itself from object_dispatch and intercept_vectors. Make these lists rather than vectors so that removal doesn't invalidate iterators. Removal can happen during the FinishDeviceSetup() loop or possibly any other vulkan call. GPU-AV is not the last entry in these lists and calls still need to happen for anything after it (currently only syncval), so playing games with vector indexing will not work.
Fixes #9412