Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Locked Figure Labels] Add/edit/delete locked function labels #1659

Merged
merged 12 commits into from
Sep 24, 2024

Commits on Sep 19, 2024

  1. Configuration menu
    Copy the full SHA
    210484d View commit details
    Browse the repository at this point in the history
  2. oops

    nishasy committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0cf13a7 View commit details
    Browse the repository at this point in the history
  3. Remove the chromatic disables because the stories actually are all vi…

    …sually different on initial load
    nishasy committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    290ff77 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ed552a4 View commit details
    Browse the repository at this point in the history
  5. [Locked Figure Labels] View locked ellipse labels

    - Add feature flag for locked ellipse labels
    - Add labels to LockedEllipseType
    - Update builder
    - Update stories and tests
    
    Issue: https://khanacademy.atlassian.net/browse/LEMS-2349
    
    Test plan:
    - Go to http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--mafs-with-locked-ellipse-labels-flag
    - Confirm that the visible label is on the locked ellipse only
    - Go to the point, line, and vector  stories and confirm that the
      locked ellipse does not have a visible label (make sure the
      flags are separating the behaviors correctly)
    nishasy committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b6769f2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f3d31a6 View commit details
    Browse the repository at this point in the history
  7. Go back to using center because the different radii and rotation make…

    … this more complex than it needs to be
    nishasy committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a0a3b6b View commit details
    Browse the repository at this point in the history
  8. [Locked Figure Labels] Add/edit/delete locked ellipse labels

    Add the ability to add/edit/delete labels for locked ellipses
    within the interactive graph editor.
    
    Issue: https://khanacademy.atlassian.net/browse/LEMS-2349
    
    Test plan:
    - Go to http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--mafs-with-locked-ellipse-labels-flag
    - Go to locked figures
    - Open the locked ellipse settings
    - Confirm that the label settings are there
    - Play around with the label settings and confirm that it moves
      and updates with the ellipse
    nishasy committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    cd061af View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. lint

    nishasy committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c90c383 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e781512 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8d62e1c View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Configuration menu
    Copy the full SHA
    d1cb602 View commit details
    Browse the repository at this point in the history