-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Locked Figure Labels] Add/edit/delete locked function labels #1659
Conversation
…sually different on initial load
- Add feature flag for locked ellipse labels - Add labels to LockedEllipseType - Update builder - Update stories and tests Issue: https://khanacademy.atlassian.net/browse/LEMS-2349 Test plan: - Go to http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--mafs-with-locked-ellipse-labels-flag - Confirm that the visible label is on the locked ellipse only - Go to the point, line, and vector stories and confirm that the locked ellipse does not have a visible label (make sure the flags are separating the behaviors correctly)
… this more complex than it needs to be
Add the ability to add/edit/delete labels for locked ellipses within the interactive graph editor. Issue: https://khanacademy.atlassian.net/browse/LEMS-2349 Test plan: - Go to http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--mafs-with-locked-ellipse-labels-flag - Go to locked figures - Open the locked ellipse settings - Confirm that the label settings are there - Play around with the label settings and confirm that it moves and updates with the ellipse
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (d1cb602) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1659 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1659 |
Size Change: +117 B (+0.01%) Total Size: 863 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1659 +/- ##
=========================================
Coverage 70.67% 70.67%
=========================================
Files 562 588 +26
Lines 108193 112825 +4632
Branches 7969 12050 +4081
=========================================
+ Hits 76460 79741 +3281
- Misses 31611 33084 +1473
+ Partials 122 0 -122 see 1150 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary:
Add the ability to add/edit/delete labels for locked functions
within the interactive graph editor.
Issue: https://khanacademy.atlassian.net/browse/LEMS-2351
Test plan:
the color updates with the function.