New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dropdown): add visual indicator when dropdown is scrollable #1832

Merged

QuintonJason merged 2 commits into develop from DSS-485/dropdown-scrolling-indicator

Oct 27, 2023

Contributor

QuintonJason commented Oct 26, 2023 •

edited

Loading

Description

add visual indicator when scrolling is available in the dropdown menu

Screenshots

Testing in `sage-lib`

Set screen height to < 775px
Visit the following views and verify that the menu shadow is present to denote scrolling in that direction
- Rails Dropdown view
- React Dropdown view

Testing in `kajabi-products`

(HIGH) Adds visual aid when dropdown is scrollable. Affects all Dropdowns when screen height is < 775px.

Related

Closes DSS-485


          fix(dropdown): add visual indicator when dropdown is scrollable

95f41f8

QuintonJason self-assigned this

QuintonJason requested a review from a team

October 26, 2023 19:35

QuintonJason marked this pull request as ready for review

October 26, 2023 19:35

pixelflips approved these changes

View reviewed changes

Member

pixelflips left a comment

It has a linting error, but overall this is a nice solution! Great work!

pixelflips requested a review from a team

October 26, 2023 20:38


          chore(dropdown): resolve properties order issue

9cd40a5

QuintonJason mentioned this pull request

Next version bump #1825

Merged

5 tasks

QuintonJason merged commit 0f7cbe6 into develop

4 checks passed

QuintonJason deleted the DSS-485/dropdown-scrolling-indicator branch

October 27, 2023 15:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet