Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next version bump #1825

Merged
merged 39 commits into from
Oct 27, 2023
Merged

Next version bump #1825

merged 39 commits into from
Oct 27, 2023

Conversation

monicawheeler
Copy link
Collaborator

@monicawheeler monicawheeler commented Oct 20, 2023

  1. (LOW) - Form Select: Rails documentation update #1808 - Documentation: Rails select component
  2. (LOW) - DSS-481: fix(hero): Update large hero max width to full #1826 - Updates max-width of large hero component. The hero should expand to the full width of its container.
    • Dashboard Hero
    • Creator Studio Hero
  3. (LOW) - Docs: Icon documentation update (React) #1818 - Documentation: Icon React component. No effect on KP.
  4. (LOW) - [DSS-473] React Form Section title #1804 - Form: Section Title
  5. (LOW) - docs(loader): update the react loader documentation #1812 - Loader: Documentation updates for both Rails and React.
  6. (HIGH) - fix(dropdown): add horizontal repositioning when space is not available #1822 - Dropdown: add horizontal repositioning for both Rails and React.
  7. (HIGH) - fix(dropdown): add visual indicator when dropdown is scrollable #1832 - Dropdown: add visual indicator when scrolling is available both Rails and React.
  8. (LOW) - docs(modal): Rails Modal Documentation #1811 - Documentation: Modal Rails component. No effect on KP.
  9. (MEDIUM) - fix(table): react table schema order #1829 - Table: Schema when applied determines the placement of the columns. Documentation updates as well.
  10. (MEDIUM) - [DSS-483] React Dropdown right & center positioning fix #1831 - Dropdown: corrects right- and center-aligned menu positioning
  • Sales -> Payments -> Transactions row overflow menu
  • Contacts -> Contact row overflow menu
  • Products -> Courses -> Course -> Quiz -> overflow menu

pixelflips and others added 16 commits October 23, 2023 09:54
DSS-481: fix(hero): Update large hero max width to full
Docs: Icon documentation update (React)
docs(loader): update the react loader documentation
This will be used in the argsTable output for Storybook
…vertical-repositioning

fix(dropdown): add horizontal repositioning when space is not available
@ju-Skinner ju-Skinner requested a review from a team October 27, 2023 15:13
@ju-Skinner ju-Skinner marked this pull request as ready for review October 27, 2023 15:13
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ator

fix(dropdown): add visual indicator when dropdown is scrollable
@pixelflips pixelflips requested a review from a team October 27, 2023 15:41
Copy link
Contributor

@QuintonJason QuintonJason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@ju-Skinner ju-Skinner merged commit 8d8c5a6 into main Oct 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants