-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next version bump #1825
Merged
Merged
Next version bump #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
monicawheeler
commented
Oct 20, 2023
•
edited by QuintonJason
Loading
edited by QuintonJason
- (LOW) - Form Select: Rails documentation update #1808 - Documentation: Rails select component
- (LOW) - DSS-481: fix(hero): Update large hero max width to full #1826 - Updates max-width of large hero component. The hero should expand to the full width of its container.
- Dashboard Hero
- Creator Studio Hero
- (LOW) - Docs: Icon documentation update (React) #1818 - Documentation: Icon React component. No effect on KP.
- (LOW) - [DSS-473] React Form Section title #1804 - Form: Section Title
- (LOW) - docs(loader): update the react loader documentation #1812 - Loader: Documentation updates for both Rails and React.
- (HIGH) - fix(dropdown): add horizontal repositioning when space is not available #1822 - Dropdown: add horizontal repositioning for both Rails and React.
- (HIGH) - fix(dropdown): add visual indicator when dropdown is scrollable #1832 - Dropdown: add visual indicator when scrolling is available both Rails and React.
- (LOW) - docs(modal): Rails Modal Documentation #1811 - Documentation: Modal Rails component. No effect on KP.
- (MEDIUM) - fix(table): react table schema order #1829 - Table: Schema when applied determines the placement of the columns. Documentation updates as well.
- (MEDIUM) - [DSS-483] React Dropdown right & center positioning fix #1831 - Dropdown: corrects right- and center-aligned menu positioning
- Sales -> Payments -> Transactions row overflow menu
- Contacts -> Contact row overflow menu
- Products -> Courses -> Course -> Quiz -> overflow menu
DSS-481: fix(hero): Update large hero max width to full
Docs: Icon documentation update (React)
[DSS-473] React Form Section title
docs(loader): update the react loader documentation
This will be used in the argsTable output for Storybook
…vertical-repositioning fix(dropdown): add horizontal repositioning when space is not available
…nchronous modal setup
docs(modal): Rails Modal Documentation
fix(table): react table schema order
[DSS-483] React Dropdown right & center positioning fix
pixelflips
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ator fix(dropdown): add visual indicator when dropdown is scrollable
QuintonJason
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.