Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSS-483] React Dropdown right & center positioning fix #1831

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[DSS-483] React Dropdown right & center positioning fix #1831

merged 1 commit into from
Oct 26, 2023

Conversation

teenwolfblitzer
Copy link
Member

@teenwolfblitzer teenwolfblitzer commented Oct 26, 2023 •
edited by jira bot
Loading

Description

The React version of the Dropdown component restricts alignment to the right of the dropdown button/trigger unless the isPinned prop is also enabled

Center alignment isn't applied whether or not isPinned is active

Screenshots

Before After
Right align before-right after-right
Center align before-center after-center

Testing in sage-lib

  1. Navigate to the Dropdown story
  2. Select “RIGHT” from the “align” menu
  3. Toggle the dropdown button in the preview window. Verify that the dropdown menu position is right-aligned
  4. Select “CENTER” from the “align” menu
  5. Verify that the dropdown menu is centered
  6. Toggle the isPinned property, verify that the dropdown menu remains centered
  7. With isPinned still active, select “RIGHT” from the “align” menu and confirm that the dropdown menu position stays right-aligned

Testing in kajabi-products

  1. (MEDIUM) Dropdown: corrects right- and center-aligned menu positioning
    • Sales -> Payments -> Transactions row overflow menu
    • Contacts -> Contact row overflow menu
    • Products -> Courses -> Course -> Quiz -> overflow menu

Related

@teenwolfblitzer teenwolfblitzer added the bug Something isn't working label Oct 26, 2023
@teenwolfblitzer teenwolfblitzer self-assigned this Oct 26, 2023
@teenwolfblitzer teenwolfblitzer marked this pull request as ready for review October 26, 2023 00:21
@teenwolfblitzer teenwolfblitzer requested review from QuintonJason and a team October 26, 2023 00:22
ju-Skinner
ju-Skinner approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@ju-Skinner ju-Skinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @monkeypox8

@ju-Skinner ju-Skinner requested a review from a team October 26, 2023 13:11
monicawheeler
monicawheeler approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@monicawheeler monicawheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻

QuintonJason
QuintonJason approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@QuintonJason QuintonJason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@teenwolfblitzer teenwolfblitzer merged commit 8474664 into develop Oct 26, 2023
4 checks passed
@teenwolfblitzer teenwolfblitzer deleted the DSS-483_react_dropdown_position_fix branch October 26, 2023 17:24
@teenwolfblitzer teenwolfblitzer mentioned this pull request Oct 26, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monicawheeler monicawheeler monicawheeler approved these changes

@ju-Skinner ju-Skinner ju-Skinner approved these changes

@QuintonJason QuintonJason QuintonJason approved these changes

Assignees

@teenwolfblitzer teenwolfblitzer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teenwolfblitzer @QuintonJason @ju-Skinner @monicawheeler