Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSS-481: fix(hero): Update large hero max width to full #1826

Merged
merged 2 commits into from
Oct 23, 2023
Merged

DSS-481: fix(hero): Update large hero max width to full #1826

merged 2 commits into from
Oct 23, 2023

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Oct 23, 2023 •
edited
Loading

Description

In some cases, the large hero does not expand to the full width of its container. This appears to be due to an incorrect max-width being set on the large hero.

This PR will update the max-width to full.

Screenshots

Before After
Docs Screenshot 2023-10-23 at 9 20 15 AM Screenshot 2023-10-23 at 9 20 35 AM
KP Screenshot 2023-10-23 at 9 21 24 AM Screenshot 2023-10-23 at 9 21 00 AM

Testing in sage-lib

  • Navigate to Hero
  • Verify Large Hero Expands to Container

Testing in kajabi-products

  1. (LOW) Updates max-width of large hero component. The hero should expand to the full width of its container.
    • Dashboard Hero
    • Creator Studio Hero

Related

DSS-481

@pixelflips pixelflips self-assigned this Oct 23, 2023
@pixelflips pixelflips added the bug Something isn't working label Oct 23, 2023
@pixelflips pixelflips marked this pull request as ready for review October 23, 2023 16:44
@pixelflips pixelflips requested a review from a team October 23, 2023 16:45
monicawheeler
monicawheeler approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@monicawheeler monicawheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@monicawheeler monicawheeler requested a review from a team October 23, 2023 16:46
@pixelflips pixelflips merged commit dbaaac5 into develop Oct 23, 2023
4 checks passed
@pixelflips pixelflips mentioned this pull request Oct 23, 2023
Merged
5 tasks
@pixelflips pixelflips deleted the DSS-481_pl-hero-max-width-full branch October 23, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monicawheeler monicawheeler monicawheeler approved these changes

@ju-Skinner ju-Skinner ju-Skinner approved these changes

Assignees

@pixelflips pixelflips

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pixelflips @ju-Skinner @monicawheeler