Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSS-473] React Form Section title #1804

Merged
merged 2 commits into from
Oct 24, 2023
Merged

[DSS-473] React Form Section title #1804

merged 2 commits into from
Oct 24, 2023

Conversation

ju-Skinner
Copy link
Collaborator

@ju-Skinner ju-Skinner commented Sep 27, 2023 •
edited by teenwolfblitzer
Loading

Description

The React Form Section title style and heading element are mismatched from the Rails component

  • Changed to default to an H5 instead of an H3
  • Makes title_tag prop available to override heading
  • Applies t-sage-heading-5 style

Screenshots

Before After
form-section-before formsection-after

Testing in sage-lib

Testing in kajabi-products

  1. (LOW) Form Section title: applies H5 element and styles as default
    • Products -> Courses -> Quiz -> Quiz settings
    • Settings -> Payment Integrations -> Other connected providers

Related

@teenwolfblitzer teenwolfblitzer force-pushed the DSS-473_react-form-section-title branch from ba6a623 to 46d3fdb Compare October 18, 2023 16:32
@teenwolfblitzer teenwolfblitzer changed the title Dss 473 react form section title [DSS-473] React Form Section title Oct 19, 2023
@teenwolfblitzer teenwolfblitzer marked this pull request as ready for review October 19, 2023 00:42
@teenwolfblitzer teenwolfblitzer requested a review from a team October 19, 2023 00:42
@teenwolfblitzer teenwolfblitzer added the enhancement New feature or request label Oct 19, 2023
pixelflips
pixelflips approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking this on! 👍🏼

@pixelflips pixelflips requested a review from a team October 19, 2023 18:40
@ju-Skinner ju-Skinner merged commit 0b3a6dc into develop Oct 24, 2023
4 checks passed
@ju-Skinner ju-Skinner mentioned this pull request Oct 24, 2023
Merged
5 tasks
@ju-Skinner ju-Skinner deleted the DSS-473_react-form-section-title branch October 24, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monicawheeler monicawheeler monicawheeler approved these changes

@pixelflips pixelflips pixelflips approved these changes

Assignees

@teenwolfblitzer teenwolfblitzer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ju-Skinner @pixelflips @monicawheeler @teenwolfblitzer