Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/title decision #164

Merged
merged 19 commits into from
Jan 16, 2025
Merged

Feature/title decision #164

merged 19 commits into from
Jan 16, 2025

Conversation

haruki26
Copy link
Contributor

@haruki26 haruki26 commented Jan 11, 2025

概要

ベクターストアへのドキュメントの作成時にタイトルを決定できるようにする

変更点

このセクションでは、具体的な変更点や修正箇所を箇条書きでリストアップしてください。

  • CosmosDBManagercreate_documentメソッドでtitleと追加のメタデータを受け取るように修正
  • ドキュメントをフォーマットする関数のdocsを追加

関連Issue

このセクションでは、このPRが関連するIssueをリンクしてください。以下のように記述します。

@github-actions github-actions bot added the enhancement 新しく機能を追加する label Jan 11, 2025
@haruki26 haruki26 requested a review from snow7y January 11, 2025 14:50
Copy link
Member

@snow7y snow7y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

特に問題なさそうです。

@haruki26
Copy link
Contributor Author

テキスト更新時は一度全消しするパワープレイにしています。

Copy link
Member

@snow7y snow7y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題ないと思います

@snow7y snow7y merged commit f6cea82 into main Jan 16, 2025
2 checks passed
@snow7y snow7y deleted the feature/title-decision branch January 16, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 新しく機能を追加する
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants