-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: cxx-qt-lib: remove cxx-qt-lib-headers and store in cxx-qt-lib #842
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,7 @@ serde_json.workspace = true | |
|
||
[build-dependencies] | ||
cxx-qt-build.workspace = true | ||
cxx-qt-lib-headers.workspace = true | ||
cxx-qt-lib.workspace = true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this causes Windows builds to fail with a missing dll 🤔 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (note it works when using cxx-qt-lib-headers, so is something specific to the build.rs and note it happened when using cxx_build instead of cxx-qt-build too) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that in #843 the same build failure occurred in |
||
|
||
[features] | ||
link_qt_object_files = [ "cxx-qt-build/link_qt_object_files" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes
cxx-qt-lib
worse to build as we need to duplicate the header copy phase :-/