WIP: cxx-qt-lib: remove cxx-qt-lib-headers and store in cxx-qt-lib #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
commented
Feb 8, 2024
| @@ -22,6 +22,7 @@ serde_json.workspace = true | |||
|
|
|||
| [build-dependencies] | |||
| cxx-qt-build.workspace = true | |||
| cxx-qt-lib.workspace = true | |||
There was a problem hiding this comment.
this causes Windows builds to fail with a missing dll 🤔
There was a problem hiding this comment.
(note it works when using cxx-qt-lib-headers, so is something specific to the build.rs and note it happened when using cxx_build instead of cxx-qt-build too)
There was a problem hiding this comment.
Note that in #843 the same build failure occurred in qml-features, the issue turned out to be having a extern "Rust" type in the bridges, removing that from the cxx-qt crate resolved the build failure.
ahayzen-kdab
force-pushed
the
319-remove-cxx-qt-lib-headers
branch
2 times, most recently
from
6b1b936 to
e8f2e26
Compare
ahayzen-kdab
commented
Feb 21, 2024
| @@ -251,5 +251,52 @@ fn main() { | |||
| }); | |||
| println!("cargo:rerun-if-changed=src/assertion_utils.h"); | |||
|
|
|||
| builder.with_opts(cxx_qt_lib_headers::build_opts()).build(); | |||
There was a problem hiding this comment.
this makes cxx-qt-lib worse to build as we need to duplicate the header copy phase :-/
This reverts commit c357722. But it fails to build on Windows due to a missing dll. It appears to happen when cxx-qt-lib is a build dependency.
ahayzen-kdab
force-pushed
the
319-remove-cxx-qt-lib-headers
branch
from
e8f2e26 to
9f8c402
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c357722.
But it fails to build on Windows due to a missing dll.
It appears to happen when cxx-qt-lib is a build dependency.
Requires #764