cxx-qt-lib: require headers to be includes manually #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
commented
Dec 6, 2023
ahayzen-kdab
force-pushed
the
319-make-cxx-qt-lib-optional
branch
from
1edf708 to
8b24374
Compare
ahayzen-kdab
commented
Dec 6, 2023
ahayzen-kdab
force-pushed
the
319-make-cxx-qt-lib-optional
branch
4 times, most recently
from
05b6d0d to
12895a7
Compare
|
Not sure why Windows is failing with a missing dll 🤔 |
ahayzen-kdab
force-pushed
the
319-make-cxx-qt-lib-optional
branch
2 times, most recently
from
43ef1b0 to
d79eff6
Compare
ahayzen-kdab
commented
Feb 6, 2024
ahayzen-kdab
force-pushed
the
319-make-cxx-qt-lib-optional
branch
2 times, most recently
from
1e1c17b to
378fdab
Compare
ahayzen-kdab
commented
Feb 8, 2024
ahayzen-kdab
force-pushed
the
319-make-cxx-qt-lib-optional
branch
2 times, most recently
from
732ace9 to
f4540ce
Compare
ahayzen-kdab
force-pushed
the
319-make-cxx-qt-lib-optional
branch
2 times, most recently
from
0fd4513 to
e1c0fe0
Compare
ahayzen-kdab
force-pushed
the
319-make-cxx-qt-lib-optional
branch
from
48d0456 to
17f8d15
Compare
ahayzen-kdab
commented
Feb 16, 2024
ahayzen-kdab
commented
Feb 16, 2024
ahayzen-kdab
force-pushed
the
319-make-cxx-qt-lib-optional
branch
4 times, most recently
from
39e5fe7 to
732d692
Compare
This allows for cxx-qt-lib to be optional later. Related to KDAB#319
When cxx-qt-lib is a build dependency we have a failure with a missing dll.
As this is how cxx bridges normally function, ideally we want this for cxx-qt bridges too but the macro needs to know the file name too.
This then means we can remove the gui and qml features
ahayzen-kdab
force-pushed
the
319-make-cxx-qt-lib-optional
branch
from
732d692 to
4774699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for cxx-qt-lib to be optional later.
Related to #319