Resolve R2 Allocation test #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpo
reviewed
Dec 30, 2024
src/utils.jl
Outdated
| stats = GenericExecutionStats(reg_nlp.model, solver_specific = Dict{Symbol, T}()) | ||
| set_solver_specific!(stats, :smooth_obj, T(Inf)) | ||
| set_solver_specific!(stats, :nonsmooth_obj, T(Inf)) | ||
| set_solver_specific!(stats, :xi, T(Inf)) |
There was a problem hiding this comment.
I don't see how
There was a problem hiding this comment.
By dual feasibility, we mean the gradient of the Lagrangian (for smooth problems). Here, the corresponding concept is
|
@dpo we should be good now I think. |
dpo
approved these changes
Jan 14, 2025
This was referenced Jan 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dpo @MohamedLaghdafHABIBOULLAH
I think this solves #161.
I added a function that constructs a
GenericExecutionStatson aRegularizedNLPModel.solver_specific entries are added during the construction, this removes the allocation in
solve!caused by adding an uninitialized solver_specific entry in stats.Also, for type stability, I had to specify that solver_specific entries are the same type as the one added in this new constructor, else there are allocations as well. This might cause issues if used without care.