Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non allocating R2N and R2DH #166

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Non allocating R2N and R2DH #166

wants to merge 16 commits into from

Conversation

MaxenceGollier
Copy link
Contributor

No description provided.

@MaxenceGollier
Copy link
Contributor Author

MaxenceGollier commented Jan 7, 2025 •
edited
Loading

@dpo @MohamedLaghdafHABIBOULLAH. Should be merged after #159 and #164.
Also, there is a small issue when comparing R2N with R2DH as a subsolver with the older version of #153, the results are very slightly different, I am still working on it.
I tested locally that there were no differences in the other case. I will show this here tomorrow.
Finally, the allocation tests will pass as soon as opnorm does not allocate and #164 is merged.

Other than that, let me know what you think.

Fyi @nathanemac.

@MaxenceGollier
Copy link
Contributor Author

MaxenceGollier commented Jan 10, 2025 •
edited
Loading

After discussing with @MohamedLaghdafHABIBOULLAH, there is an error in the original version which explains the differences with R2N called with R2DH.
I think we can start to review this PR @dpo though I need #164 to be merged first for this to work (and in order to show the benchmarks and test that the results are the same with the older version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MaxenceGollier