-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full support of sparse AD for NLS models #239
Conversation
@amontoison I keep this in my list. Could you rebase the branch? |
1e002d5
to
a01f52d
Compare
@tmigot Done |
@amontoison I took care of the ADNLPModel-stuff, just rest to fix |
1363b41
to
f05d97d
Compare
@tmigot I think we need to create the backend for |
@tmigot Tu sais à quoi ça sert ces lignes? |
C'est pour couvrir le cas où le "backend" fourni par l'utilisateur est un NLPModel. Mais définir cette fonction
devrait être suffisant je pense. |
d37a9a1
to
afe470c
Compare
@tmigot All tests passed for Hessian but we probably need to update the API for |
Thanks for fixing it. I think the implementation in AD&NLPModels of jth_residual_hess is not clear so I removed the additional implementation (JuliaSmoothOptimizers/NLPModels.jl#466). It should work now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amontoison ! LGTM
@tmigot Can you help me with it?