Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpful message when ProductManifold is used without RAT.jl #201

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

mateuszbaran
Copy link
Member

I had to change representation_size for ProductManifold for this but I think it doesn't make that much sense anyway.

@mateuszbaran mateuszbaran added preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready labels Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (8469ef9) to head (2753277).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          31       31           
  Lines        3294     3300    +6     
=======================================
+ Hits         3291     3297    +6     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellertuer
Copy link
Member

One could consider this breaking since it introduces an error in some cases; but I think instead of nothing being more careful with that is more like improve the user experience, so that is fine with me even in a nonbreaking sense.

@mateuszbaran
Copy link
Member Author

Yes, it's technically breaking but it's a part that no one should rely on.

@mateuszbaran mateuszbaran merged commit 1bc2c94 into master Aug 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants