Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored error message when no RAT.jl #202

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

mateuszbaran
Copy link
Member

A small improvement to #201 to make it easier to handle another similar issue in Manifolds.jl, regarding identity_element.

@mateuszbaran mateuszbaran added the Ready-for-Review A label for pull requests that are feature-ready label Aug 29, 2024
Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-spotted.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (1bc2c94) to head (ddde712).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          31       31           
  Lines        3300     3302    +2     
=======================================
+ Hits         3297     3299    +2     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mateuszbaran mateuszbaran merged commit 0e45f73 into master Aug 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants