Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to fix tests and docs #43

Merged
merged 13 commits into from
Nov 6, 2023
Merged

try to fix tests and docs #43

merged 13 commits into from
Nov 6, 2023

Commits on Nov 5, 2023

  1. use a writable property to test notify

    @jwahlstrand
    jwahlstrand committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    fb8902a View commit details
    Browse the repository at this point in the history

  2. add another doc file, disable signal_emit test

    @jwahlstrand
    jwahlstrand committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    f79287f View commit details
    Browse the repository at this point in the history

  3. disable more tests

    @jwahlstrand
    jwahlstrand committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    04736f2 View commit details
    Browse the repository at this point in the history

  4. reorganize tests, try the simpler signal_connect for "notify"

    @jwahlstrand
    jwahlstrand committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    80c3e57 View commit details
    Browse the repository at this point in the history

  5. print the arguments of the callback

    @jwahlstrand
    jwahlstrand committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    cff6157 View commit details
    Browse the repository at this point in the history

  6. test a hypothesis

    @jwahlstrand
    jwahlstrand committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    ca500b0 View commit details
    Browse the repository at this point in the history

  7. disable the tests

    @jwahlstrand
    jwahlstrand committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    4640b92 View commit details
    Browse the repository at this point in the history

  8. split tests up 

    trying to isolate the problem
    @jwahlstrand
    jwahlstrand committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    8560ee5 View commit details
    Browse the repository at this point in the history

  9. more of the same

    @jwahlstrand
    jwahlstrand committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    e9a1409 View commit details
    Browse the repository at this point in the history

  10. try enabling all tests again

    @jwahlstrand
    jwahlstrand committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    dff082f View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. try to diagnose dialog crash

    @jwahlstrand
    jwahlstrand committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    f609c58 View commit details
    Browse the repository at this point in the history

  2. use close rather than destroy 

    It looks like the main window is being destroyed before the dialogs have been freed. Using close seems to have the same effect but lets GTK destroy everything gracefully?
    @jwahlstrand
    jwahlstrand committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    0d2dd8e View commit details
    Browse the repository at this point in the history

  3. unset parent window before destroying dialogs

    @jwahlstrand
    jwahlstrand committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    61123c4 View commit details
    Browse the repository at this point in the history