Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix tests and docs #43

Merged
merged 13 commits into from
Nov 6, 2023
Merged

try to fix tests and docs #43

merged 13 commits into from
Nov 6, 2023

Conversation

jwahlstrand
Copy link
Member

@jwahlstrand jwahlstrand commented Nov 5, 2023

Tests of the cfunction-based signal connect were segfaulting. This prevents that by splitting up the tests -- apparently the interaction of different callbacks was doing this? I will look into this further when I get a chance.

Also finally fixes a crash in the dialog tests that has popped up recently. I have never observed this crash outside the tests.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2023

Codecov Report

Merging #43 (0d2dd8e) into main (889fdd2) will increase coverage by 1.34%.
The diff coverage is 33.33%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   84.86%   86.21%   +1.34%     
==========================================
  Files          43       43              
  Lines        4534     4438      -96     
==========================================
- Hits         3848     3826      -22     
+ Misses        686      612      -74     
Files Coverage Δ
src/GLib/gvalues.jl 86.66% <100.00%> (+6.09%) ⬆️
src/GLib/gtype.jl 89.72% <0.00%> (-1.99%) ⬇️

... and 6 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jwahlstrand jwahlstrand merged commit 09682e4 into main Nov 6, 2023
11 checks passed
@jwahlstrand jwahlstrand deleted the jw/fixes branch November 13, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants