Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ReverseDiff type annotations #498

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Clean up ReverseDiff type annotations #498

merged 3 commits into from
Sep 25, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 25, 2024

DI extensions

  • ReverseDiff: Clean up useless type annotations

@gdalle gdalle linked an issue Sep 25, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (d9a5cab) to head (b38de29).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   98.42%   98.42%   -0.01%     
==========================================
  Files         106      106              
  Lines        4381     4380       -1     
==========================================
- Hits         4312     4311       -1     
  Misses         69       69              
Flag Coverage Δ
DI 98.48% <100.00%> (-0.01%) ⬇️
DIT 98.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle changed the title Remove unneeded evaluation for ReverseDiff Clean up ReverseDiff type annotations Sep 25, 2024
@gdalle gdalle merged commit 987ca87 into main Sep 25, 2024
60 checks passed
@gdalle gdalle deleted the gd/revdiff branch September 25, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants