Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReverseDiff's value_and_gradient! #387

Open
gdalle opened this issue Jul 28, 2024 · 0 comments
Open

Fix ReverseDiff's value_and_gradient! #387

gdalle opened this issue Jul 28, 2024 · 0 comments
Labels
backend Related to one or more autodiff backends

Comments

@gdalle
Copy link
Member

gdalle commented Jul 28, 2024 •
edited
Loading

As diagnosed in #386, the function value_and_gradient!(f, grad, ::AutoReverseDiff, x) returns wrong primal outputs y = f(x) due to JuliaDiff/ReverseDiff.jl#251. #386 fixes it, but at the cost of one extra function call. The long-term fix is something like JuliaDiff/ReverseDiff.jl#261
@gdalle gdalle added the backend Related to one or more autodiff backends label Jul 29, 2024
@gdalle gdalle linked a pull request Sep 25, 2024 that will close this issue
Clean up ReverseDiff type annotations #498
Merged
@gdalle gdalle removed a link to a pull request Sep 25, 2024
Clean up ReverseDiff type annotations #498
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Related to one or more autodiff backends
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gdalle