Test ForwardDiff over ReverseDiff #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
==========================================
- Coverage 96.58% 94.49% -2.10%
==========================================
Files 101 101
Lines 4926 4921 -5
==========================================
- Hits 4758 4650 -108
- Misses 168 271 +103 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DI extensions
f(x)invalue_and_gradientandvalue_and_hessian, to compensate for DiffResults objects are not re-aliased properly ReverseDiff.jl#251DI tests
SecondOrder(AutoForwardDiff(), AutoReverseDiff())AutoReverseDiff()Caution
Without the extension modification, the new tests fail on the primal value
y = f(x)when it comes fromvalue_and_gradient!(f, ::AutoReverseDiff, x). My best guess for the culprit is the bad use of DiffResults inside ReverseDiff (JuliaDiff/ReverseDiff.jl#251). Funnily enough, the tests succeed if I add aprintlnstatement in said function, which is very disturbing (see Discourse on the side effects ofprintln).