Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache the LU factorisation in the direct linear solver and better static array support #64

Merged
merged 8 commits into from
Jul 30, 2023
Merged

cache the LU factorisation in the direct linear solver and better static array support #64

merged 8 commits into from
Jul 30, 2023

Conversation

mohamed82008
Copy link
Collaborator

This fixes #59 and #58. Needs tests.

@codecov
Copy link

codecov bot commented Jun 3, 2023 •
edited
Loading

Codecov Report

Patch coverage: 89.21% and project coverage change: +5.44% 🎉

Comparison is base (70dab9e) 86.27% compared to head (c6a0459) 91.72%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   86.27%   91.72%   +5.44%     
==========================================
  Files           5        9       +4     
  Lines         102      145      +43     
==========================================
+ Hits           88      133      +45     
+ Misses         14       12       -2
Files Changed Coverage Δ
src/ImplicitDifferentiation.jl 66.66% <50.00%> (-8.34%) ⬇️
src/conditions.jl 71.42% <71.42%> (ø)
src/linear_solver.jl 75.00% <75.00%> (ø)
src/forward.jl 83.33% <83.33%> (ø)
src/implicit_function.jl 88.00% <88.00%> (+22.61%) ⬆️
ext/ImplicitDifferentiationChainRulesExt.jl 100.00% <100.00%> (ø)
ext/ImplicitDifferentiationForwardDiffExt.jl 100.00% <100.00%> (ø)
ext/ImplicitDifferentiationStaticArraysExt.jl 100.00% <100.00%> (ø)
src/utils.jl 100.00% <100.00%> (+21.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamed82008 mohamed82008 mentioned this pull request Jun 25, 2023
Closed
@gdalle
Copy link
Member

gdalle commented Jul 5, 2023

Gentle ping on this @mohamed82008, with zero pressure though

mohamed82008
mohamed82008 commented Jul 5, 2023
View reviewed changes
src/implicit_function.jl Outdated Show resolved Hide resolved
mohamed82008
mohamed82008 commented Jul 5, 2023
View reviewed changes
src/linear_solver.jl Outdated Show resolved Hide resolved
mohamed82008
mohamed82008 commented Jul 5, 2023
View reviewed changes
test/systematic.jl Outdated Show resolved Hide resolved
mohamed82008
mohamed82008 commented Jul 5, 2023
View reviewed changes
test/systematic.jl Outdated Show resolved Hide resolved
mohamed82008
mohamed82008 commented Jul 5, 2023
View reviewed changes
test/systematic.jl Outdated Show resolved Hide resolved
mohamed82008
mohamed82008 commented Jul 5, 2023
View reviewed changes
test/systematic.jl Outdated Show resolved Hide resolved
@gdalle gdalle changed the title [draft] cache the LU factorisation in the direct linear solver and better static array support cache the LU factorisation in the direct linear solver and better static array support Jul 28, 2023
@gdalle
Copy link
Member

gdalle commented Jul 28, 2023

New docs preview: https://gdalle.github.io/ImplicitDifferentiation.jl/previews/PR64/

mohamed82008
mohamed82008 commented Jul 29, 2023
View reviewed changes
examples/1_basic.jl Outdated Show resolved Hide resolved
mohamed82008
mohamed82008 commented Jul 29, 2023
View reviewed changes
examples/1_basic.jl Outdated Show resolved Hide resolved
@gdalle gdalle linked an issue Jul 30, 2023 that may be closed by this pull request
Add example use of byproduct #62
Closed
@mohamed82008 mohamed82008 mentioned this pull request Jul 30, 2023
Closed
@mohamed82008
Copy link
Collaborator Author

Looks ready 🎉

@gdalle gdalle merged commit 2c50679 into main Jul 30, 2023
6 checks passed
@mohamed82008 mohamed82008 mentioned this pull request Jul 30, 2023
Closed
@gdalle gdalle deleted the mt/presolve branch August 4, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdalle gdalle gdalle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add example use of byproduct Direct linear solver not efficiently handled
2 participants
@mohamed82008 @gdalle