Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test static arrays and use direct linear solver #58

Closed
mohamed82008 opened this issue May 27, 2023 · 1 comment
Closed

Test static arrays and use direct linear solver #58

mohamed82008 opened this issue May 27, 2023 · 1 comment
Labels
feature New feature or request

Comments

@mohamed82008
Copy link
Collaborator

I think we should add tests for static array inputs and outputs. Ideally we should remain static throughout the whole computation. Also a nice heuristic could be to use a direct linear solver whenever static arrays are used instead of gmres.
@gdalle gdalle added the feature New feature or request label May 30, 2023
@mohamed82008 mohamed82008 mentioned this issue Jun 3, 2023
Merged
@gdalle gdalle changed the title test static arrays and use direct linear solver Test static arrays and use direct linear solver Jul 30, 2023
@mohamed82008
Copy link
Collaborator Author

Fixed by #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mohamed82008 @gdalle