Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AlterMakeham, AlterGompertz, Carriere1 and Carriere2 models #120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

leeyuntien
Copy link

This is in response to the issue #46 Parameterized Models to add 4 models, including AlterMakeham, AlterGompertz, Carriere1 and Carriere2.

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #120 (1b9c1ca) into master (e7a98fe) will decrease coverage by 9.20%.
The diff coverage is 0.00%.

❗ Current head 1b9c1ca differs from pull request most recent head d962232. Consider uploading reports for the commit d962232 to get more accurate results

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   89.97%   80.77%   -9.20%     
==========================================
  Files           9        9              
  Lines         369      411      +42     
==========================================
  Hits          332      332              
- Misses         37       79      +42     
Impacted Files Coverage Δ
src/parameterized_models.jl 77.04% <0.00%> (-21.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alecloudenback
Copy link
Member

Thank you! Can you also add tests?

I may be a bit delayed in reviewing the PRs, thank you for your patience!

@@ -48,6 +48,44 @@ end
survival(m::Makeham,age) = exp(-cumhazard(m,age))


"""
AlterMakeham(;μ,σ,c)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Makeham2 would be more consistent with the rest of the names. Same with AlterGompertz

Copy link
Member

@alecloudenback alecloudenback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo:

  • Change the AlterMakeham names to a Makeham2
  • Add tests to compare the answers to a different source

@alecloudenback
Copy link
Member

Hey @leeyuntien you commented on the associated issue. The reason I haven't merged this is to address the "to-dos" in my prior comment.

@alecloudenback alecloudenback mentioned this pull request Feb 11, 2023
4 tasks
@yuntienlee
Copy link

Hey @leeyuntien you commented on the associated issue. The reason I haven't merged this is to address the "to-dos" in my prior comment.

i have changed some function names in the fork more-model, please review, thanks

@alecloudenback
Copy link
Member

Thanks for making the name changes. Can you add some test cases? E.g. see some of the existing cases here: https://github.com/JuliaActuary/MortalityTables.jl/blob/master/test/parameterized_models.jl

Before merging new things we try to ensure correctness by testing the output of the new features/code.

If you need help with that I can do one of the functions you added as an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants