-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterized Models #46
Comments
The models themselves are good first issues, but the method/API is more advanced |
Major progress in #75 |
Would also like to contribute to this issue. Please advise next steps. Thanks! |
IIRC, the first two listed above are just alternate formulations of the standard Gompertz/Makeham formulas. Implementation should be straightforward (ref the MIT-licensed R package MortalityLaws), but it would be good to put thought into if there is a better name than The Carrrie ones, IIRC are combinations of other distirbutions? If that's the right memory, than one possible implementation would be a new |
Tried to implement and added AlterMakeham, AlterGompertz, Carriere1 and Carriere2 and updated parameterized_models.jl. Please advise how it can be uploaded/pulled to review. |
Awesome! Check out this article about creating a pull request: https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github A PR will allow the automated tests/checks to occur and makes it easy to review the changes. |
My bad not to keep this up to date. Are these issues still open, since there does not seem carriere models? Thanks. |
There was a comment on this issue but it seemed disappeared. Can you advise what the status is again? Thanks. |
Hey, I think you may be referring to the open PR, which just needs tests before merging: #120 (comment) |
Add the remaining parametric models. A great reference for the formulas is in https://github.com/mpascariu/MortalityLaws and would require adding them to
src/parameterized_models.jl
and adding some tests.The text was updated successfully, but these errors were encountered: