Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterized Models #46

Open
4 tasks
alecloudenback opened this issue May 22, 2020 · 10 comments
Open
4 tasks

Parameterized Models #46

alecloudenback opened this issue May 22, 2020 · 10 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@alecloudenback
Copy link
Member

alecloudenback commented May 22, 2020

Add the remaining parametric models. A great reference for the formulas is in https://github.com/mpascariu/MortalityLaws and would require adding them to src/parameterized_models.jl and adding some tests.

  • gompertz0
  • makeham0
  • carriere1
  • carriere2
@alecloudenback alecloudenback added the enhancement New feature or request label May 22, 2020
@alecloudenback alecloudenback added this to the Version 1.0 milestone May 22, 2020
@alecloudenback
Copy link
Member Author

The models themselves are good first issues, but the method/API is more advanced

@alecloudenback alecloudenback added the good first issue Good for newcomers label May 22, 2020
@alecloudenback
Copy link
Member Author

Partially done in #47 and #45

@alecloudenback
Copy link
Member Author

Major progress in #75

@alecloudenback alecloudenback removed this from the Version 1.0 milestone Sep 13, 2020
@leeyuntien
Copy link

Would also like to contribute to this issue. Please advise next steps. Thanks!

@alecloudenback
Copy link
Member Author

IIRC, the first two listed above are just alternate formulations of the standard Gompertz/Makeham formulas. Implementation should be straightforward (ref the MIT-licensed R package MortalityLaws), but it would be good to put thought into if there is a better name than Name0.

The Carrrie ones, IIRC are combinations of other distirbutions? If that's the right memory, than one possible implementation would be a new struct with the underlying parametric models passed as its fields.

@leeyuntien
Copy link

Tried to implement and added AlterMakeham, AlterGompertz, Carriere1 and Carriere2 and updated parameterized_models.jl. Please advise how it can be uploaded/pulled to review.

@alecloudenback
Copy link
Member Author

Awesome! Check out this article about creating a pull request: https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github

A PR will allow the automated tests/checks to occur and makes it easy to review the changes.

@leeyuntien
Copy link

My bad not to keep this up to date. Are these issues still open, since there does not seem carriere models? Thanks.

@leeyuntien
Copy link

There was a comment on this issue but it seemed disappeared. Can you advise what the status is again? Thanks.

@alecloudenback
Copy link
Member Author

Hey, I think you may be referring to the open PR, which just needs tests before merging: #120 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
Status: New features
Development

No branches or pull requests

2 participants