Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add optional name/limit/password props for createNewAccessKey method #1273

Merged

Conversation

murka
Copy link
Contributor

@murka murka commented Jan 24, 2023

No description provided.

@murka murka requested a review from fortuna as a code owner January 24, 2023 18:51
@murka murka changed the title feat: add optional name and limit props for createNewAccessKey method feat(shadowbox): add optional name and limit props for createNewAccessKey method Jan 24, 2023
@murka murka marked this pull request as draft January 26, 2023 15:01
@murka murka changed the title feat(shadowbox): add optional name and limit props for createNewAccessKey method feat(server): add optional name and limit props for createNewAccessKey method Jan 26, 2023
@murka murka marked this pull request as ready for review January 26, 2023 19:46
@murka murka marked this pull request as draft February 4, 2023 08:02
@fortuna
Copy link
Collaborator

fortuna commented Feb 6, 2023

@murka Could you add a bit of background on why you need this change?
What are you trying to accomplish?

@murka
Copy link
Contributor Author

murka commented Apr 17, 2023

@fortuna, I would like to add options when creating a key, right now it takes three steps to create a key, change the name and add restrictions.

@murka murka marked this pull request as ready for review July 19, 2023 22:03
@murka
Copy link
Contributor Author

murka commented Jul 27, 2023

@fortuna This PR is ready to merge! The PR is not blocking compatibility for previous server versions, because new props is optional.

https://github.com/murka/outline-server/actions/runs/5685731607

@vatrubin
Copy link

vatrubin commented Sep 5, 2023

@murka Could you add a password field? I would like to synchronize passwords between several servers, but this cannot be done through the API.

@murka
Copy link
Contributor Author

murka commented Sep 11, 2023

@vatrubin, no, it's not completion for this PR, password will be automatically generated for each accessKey. You can sync opt file storage for between servers.

@murka
Copy link
Contributor Author

murka commented Dec 11, 2023

@fortuna @daniellacosse, any updates?

@murka murka requested a review from a team as a code owner December 30, 2023 20:01
@murka murka requested a review from fortuna December 30, 2023 21:38
src/shadowbox/model/access_key.ts Show resolved Hide resolved
src/shadowbox/server/manager_service.ts Outdated Show resolved Hide resolved
src/shadowbox/server/manager_service.ts Outdated Show resolved Hide resolved
Co-authored-by: Vinicius Fortuna <[email protected]>
src/shadowbox/server/manager_service.ts Show resolved Hide resolved
src/shadowbox/server/manager_service.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the test. I realize that one issue was not addressed.

src/shadowbox/server/manager_service.ts Outdated Show resolved Hide resolved
@fortuna
Copy link
Collaborator

fortuna commented Jan 11, 2024

Oh, there are still tests failing when you run npm run action shadowbox/test.
See https://github.com/Jigsaw-Code/outline-server/actions/runs/7469550377/job/20371104279?pr=1273

@murka
Copy link
Contributor Author

murka commented Jan 11, 2024

@murka murka requested a review from fortuna January 11, 2024 19:13
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution and patience!

@fortuna fortuna merged commit 57a30a2 into Jigsaw-Code:master Jan 12, 2024
14 checks passed
@murka murka deleted the feat-createNewAccessKey-name-datalimit branch January 12, 2024 21:01
method:
type: string
password:
type: string
port:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think port was not implemented as part of this PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jadolg I think you are right. You can still set the port for new access keys if you want to do that, but we should add it to the key creation API as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll send a PR to add this.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also review the PUT method. I think it's wired to the same method so it should not work either but the docs claim it does.

jadolg added a commit to jadolg/outline-vpn-api that referenced this pull request Feb 5, 2024
even though it was added to the API spec, the parameter is missing from implementation. See Jigsaw-Code/outline-server#1273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants