Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): extend key creation API to allow specifying a port #1505

Merged
merged 7 commits into from
Feb 7, 2024

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Feb 6, 2024

This was documented as part of #1273 and #1473 but not actually implemented. See #1273 (comment).

src/shadowbox/server/server_access_key.ts Outdated Show resolved Hide resolved
@sbruens sbruens requested a review from fortuna February 6, 2024 22:30
@sbruens sbruens requested a review from fortuna February 6, 2024 22:48
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! Do you wanna start a release? It's quite straightforward

src/shadowbox/server/server_access_key.ts Show resolved Hide resolved
src/shadowbox/server/server_access_key.ts Show resolved Hide resolved
@sbruens sbruens merged commit 88cee12 into master Feb 7, 2024
14 checks passed
@sbruens sbruens deleted the sbruens/port-creation branch February 7, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants