Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet #935

Merged
merged 15 commits into from
Jul 8, 2024
Merged

Fleet #935

merged 15 commits into from
Jul 8, 2024

Commits on Jul 4, 2024

  1. Move toggleInsertOverwrite() to VimEditor

    If we execute it from VimStateMachine directly, then mode change listeners are not notified
    lippfi committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    0ee30e7 View commit details
    Browse the repository at this point in the history
  2. Make VimStateMachine global

    It is global in Vim
    lippfi committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    03de34e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ca87022 View commit details
    Browse the repository at this point in the history
  4. Fix(VIM-3462): IdeaVim not responsive occasionally

    This bug was caused by two reasons:
    1. KeyHandler state is not longer per-editor and we can't reset it on editor creation
    2. We do not need to do such things on editor creation. What actually matters is focusing the editor
    lippfi committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    adea9e8 View commit details
    Browse the repository at this point in the history
  5. Remove ideaglobalmode option

    Mode is global now
    lippfi committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    eac6189 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2492a90 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Introduce new interface for VimOutputPanel to support the output pane…

    …l in Fleet
    
    Why is the old interface bad?
    - it is not obvious. You cannot create a new panel or check if it is already created. Only "getOrCreate" it
    - output panel is bound to editor while in Vim it is global
    - we have the `isActive` field and the `clear()` method at the same time, because interface implies that you store the same instance of the panel and reactivate it for each output and I don't like it. We also can forget to call `clear()` after reusing panel
    - we cannot "build" output before showing to make the panel more efficient. With multiple carets we can only cal `output(oldText + newText)` for each caret, and it is bad. (imagine we have global command with a lot of matches and for each time we will need to call the `output(oldText + newText)`)
    - the `output()` method shows panel, activates it and updates it
    - there are more things that I do not like, but the points above should be already enough
    lippfi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    0f4d385 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    30016ce View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e2c4703 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    44144e9 View commit details
    Browse the repository at this point in the history
  5. Safer VimListenersNotifier

    lippfi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    bd396e2 View commit details
    Browse the repository at this point in the history
  6. Remove KeyHandlerStateResetter

    It's an oneliner that we can live without
    lippfi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    b769d40 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e4e3c6f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0043347 View commit details
    Browse the repository at this point in the history
  9. Fix project leak

    lippfi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    b5dc866 View commit details
    Browse the repository at this point in the history